On Fri, Jan 8, 2021 at 7:29 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > On 2021/01/07 17:21, Bharath Rupireddy wrote: > > On Thu, Jan 7, 2021 at 9:49 AM Fujii Masao <masao.fu...@oss.nttdata.com> > > wrote: > >> On 2021/01/05 16:56, Bharath Rupireddy wrote: > >>> Attaching v8 patch set. Hopefully, cf bot will be happy with v8. > >>> > >>> Please consider the v8 patch set for further review. > >> -DATA = postgres_fdw--1.0.sql > >> +DATA = postgres_fdw--1.1.sql postgres_fdw--1.0--1.1.sql > >> > >> Shouldn't we leave 1.0.sql as it is and create 1.0--1.1.sql so that > >> we can run the followings? > >> > >> CREATE EXTENSION postgres_fdw VERSION "1.0"; > >> ALTER EXTENSION postgres_fdw UPDATE TO "1.1"; > > > > Yes we can. In that case, to use the new functions users have to > > update postgres_fdw to 1.1, in that case, do we need to mention in the > > documentation that to make use of the new functions, update > > postgres_fdw to version 1.1? > > But since postgres_fdw.control indicates that the default version is 1.1, > "CREATE EXTENSION postgres_fdw" installs v1.1. So basically the users > don't need to update postgres_fdw from v1.0 to v1.1. Only the users of > v1.0 need to update that to v1.1 to use new functions. No?
It works this way: scenario 1: 1) create extension postgres_fdw; --> this is run before our feature i.e default_version 1.0 2) after the feature i..e default_version 1.1, users can run alter extension postgres_fdw update to "1.1"; which gets the new functions from postgres_fdw--1.0--1.1.sql. scenario 2: 1) create extension postgres_fdw; --> this is run after our feature i.e default_version 1.1, then the new functions will be installed with create extension itself, no need to run alter update to get the functions, I will make the changes and post a new patch set soon. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
