On Tue, Jan 5, 2021 at 10:41 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > 3. > > > +#define SUBREL_STATE_COPYDONE 'C' /* tablesync copy phase is completed */ > > > > > > You can mention in the comments that sublsn will be NULL for this > > > state as it is mentioned for other similar states. Can we think of > > > using any letter in lower case for this as all other states are in > > > lower-case except for this which makes it a look bit odd? We can use > > > 'f' or 'e' and describe it as 'copy finished' or 'copy end'. I am fine > > > if you have any better ideas. > > > > > > > Fixed in latest patch [v11] > > > > It is still not reflected in the docs. See below: > --- a/doc/src/sgml/catalogs.sgml > +++ b/doc/src/sgml/catalogs.sgml > @@ -7651,6 +7651,7 @@ SCRAM-SHA-256$<replaceable><iteration > count></replaceable>:<replaceable>&l > State code: > <literal>i</literal> = initialize, > <literal>d</literal> = data is being copied, > + <literal>C</literal> = table data has been copied, > <literal>s</literal> = synchronized, >
Fixed in latest patch [v12] ---- [v12] = https://www.postgresql.org/message-id/CAHut%2BPsonJzarxSBWkOM%3DMjoEpaq53ShBJoTT9LHJskwP3OvZA%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia
