On Thu, Dec 24, 2020 at 7:40 AM Michael Paquier <mich...@paquier.xyz> wrote: > > On Wed, Dec 23, 2020 at 07:13:33PM +0530, Bharath Rupireddy wrote: > > +1. Shall we add some test cases(with xml, yaml, json formats as is > > currently being done in explain.sql) to cover that? We can have the > > explain_filter() function to remove the unstable parts in the output, > > it looks something like below. If yes, please let me know I can add > > them to matview and select_into. > > I am not sure that we need tests for all the formats, but having at > least one of them sounds good to me. I leave the choice up to you.
Since I tested that with all the formats manually here and it works, so I don't want to make the test cases complicated with adding explain_filter() function into matview.sql and select_into.sql and all that. I'm okay without those test cases. > What we have here looks rather committable. Let's wait until the > period of vacations is over before wrapping this up to give others the > occasion to comment. Thanks! Happy Vacations! With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
