Hi,
On 2020-12-02 13:52:43 +0900, Fujii Masao wrote:
> Pushed. Thanks!
Why are wal_records/fpi long, instead of uint64?
long wal_records; /* # of WAL records produced */
long wal_fpi; /* # of WAL full page images
produced */
uint64 wal_bytes; /* size of WAL records produced
*/
long is only 4 byte e.g. on windows, and it is entirely possible to wrap
a 4 byte record counter. It's also somewhat weird that wal_bytes is
unsigned, but the others are signed?
This is made doubly weird because on the SQL level you chose to make
wal_records, wal_fpi bigint. And wal_bytes numeric?
Greetings,
Andres Freund
