Hi, On 2020-12-08 11:05:05 -0500, Tom Lane wrote: > I've now studied this patch and it seems sane to me, although > I wondered why you wrote "extern"s here:
Brainfart... > Other than that nit, please finish this up and push it so I can finish > the generic-subscripting patch. Done. > > WRT the prototype, I think it may be worth removing most of the types > > from llvmjit.h. Worth keeping the most common ones, but most aren't used > > all the time so terseness doesn't matter that much, and > > the llvm_pg_var_type() would suffice. > > Hm, that would mean redoing llvm_pg_var_type() often wouldn't it? > I don't have a very good feeling for how expensive that is, so I'm > not sure if this seems like a good idea or not. It should be fairly cheap - it's basically one hashtable lookup. Greetings, Andres Freund
