Peter Eisentraut <peter.eisentr...@enterprisedb.com> writes: > While doing the proverbial other things, I noticed that the grammar > symbols publication_name_list and publication_name_item are pretty > useless. We already use name_list/name to refer to publications in most > places, so getting rid of these makes things more consistent.
+1. Strictly speaking, this reduces the set of keywords that you can use as names here (since name is ColId, versus ColLabel in publication_name_item). However, given the inconsistency with other commands, I don't see it as an advantage to be more forgiving in just one place. We might have problems preserving the laxer definition anyway, if the syntaxes of these commands ever get any more complicated. regards, tom lane