On Wed, Dec 02, 2020 at 10:30:08PM -0600, Justin Pryzby wrote: > Good idea. I think you mean like this.
Yes, something like that. Thanks.
> +typedef struct ReindexParams {
> + bool concurrently;
> + bool verbose;
> + bool missingok;
> +
> + int options; /* bitmask of lowlevel REINDEXOPT_* */
> +} ReindexParams;
> +
By moving everything into indexcmds.c, keeping ReindexParams within it
makes sense to me. Now, there is no need for the three booleans
because options stores the same information, no?
> struct ReindexIndexCallbackState
> {
> - int options; /* options from
> statement */
> + bool concurrently;
> Oid locked_table_oid; /* tracks previously
> locked table */
> };
Here also, I think that we should just pass down the full
ReindexParams set.
--
Michael
signature.asc
Description: PGP signature
