Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost <sfr...@snowman.net> writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> I took a quick look through this. This is just MHO, of course: > >> > >> * I don't think it's okay to change the existing signatures of > >> pg_ls_logdir() et al. > > > I disagree that we need to stress over this- we pretty routinely change > > the signature of various catalogs and functions and anyone using these > > is already of the understanding that we are free to make such changes > > between major versions. > > Well, like I said, just MHO. Anybody else want to weigh in? > > I'm mostly concerned about removing the isdir output of pg_stat_file(). > Maybe we could compromise to the extent of keeping that, allowing it > to be partially duplicative of a file-type-code output column.
I don't have any particular issue with keeping isdir as a convenience column. I agree it'll now be a bit duplicative but that seems alright. Thanks, Stephen
signature.asc
Description: PGP signature