On Tue, Nov 24, 2020 at 3:04 AM Anastasia Lubennikova <a.lubennik...@postgrespro.ru> wrote: > > On 27.10.2020 13:46, Amit Kapila wrote: > > On Sun, Oct 25, 2020 at 9:39 PM Euler Taveira > > <euler.tave...@2ndquadrant.com> wrote: > >> On Mon, 5 Oct 2020 at 08:34, Amit Kapila <amit.kapil...@gmail.com> wrote: > >>> On Mon, May 11, 2020 at 2:41 AM Euler Taveira > >>> <euler.tave...@2ndquadrant.com> wrote: > >>>> Hi, > >>>> > >>>> While looking at an old wal2json issue, I stumbled on a scenario that a > >>>> table > >>>> with a deferred primary key is not updatable in logical replication. > >>>> AFAICS it > >>>> has been like that since the beginning of logical decoding and seems to > >>>> be an > >>>> oversight while designing logical decoding. > >>>> > >>> I am not sure if it is an oversight because we document that the index > >>> must be non-deferrable, see "USING INDEX records the old values of the > >>> columns covered by the named index, which must be unique, not partial, > >>> not deferrable, and include only columns marked NOT NULL." in docs > >>> [1]. > >>> > >> Inspecting this patch again, I forgot to consider that > >> RelationGetIndexList() > >> is called by other backend modules. Since logical decoding deals with > >> finished > >> transactions, it is ok to use a deferrable primary key. > >> > > But starting PG-14, we do support logical decoding of in-progress > > transactions as well. > > > > > Commitfest entry status update. > As far as I see, this patch needs some further work, so I move it to > "Waiting on author". >
I think this should be marked as "Returned with Feedback" as there is no response to the feedback for a long time and also it is not very clear if this possible. -- With Regards, Amit Kapila.
