Hi, Am Mittwoch, den 28.10.2020, 21:44 -0500 schrieb Justin Pryzby: > Forking this thread: > https://www.postgresql.org/message-id/fd93f1c5-7818-a02c-01e5-1075ac0d4...@iki.fi
Glancing over this in the context of pg_standby/pg_archivecleanup, I am not sure Heikki's "Ditto" is about "remove pg_archivecleanup just like pg_standby" or rather "keep the note until we get around doing something with it". Probably the former, but see below. > I think these are old-fashioned since 9.6 (?), so remove them for v14. Why 9.6? > I found it confusing when re-familiarizing myself with modern streaming > replication that there are extensions which only help do things the "old way". I guess not many will complain about pg_standby going away, but I am under the impression that pg_archivecleanup is still used a lot in PITR backup environments as a handy tool to expire WAL related to expired base backups. I certainly saw hand-assembled shell code fail with "too many files" and things when it tried to act on large amount of WAL. So I think the part about it being used in archive_cleanup_command can be probably be removed, but the part about it being useful as a stand- alone tool, in particular this part: |In this mode, if you specify a .partial or .backup file name, then only |the file prefix will be used as the oldestkeptwalfile. This treatment |of .backup file name allows you to remove all WAL files archived prior |to a specific base backup without error. At the very least, the commit message should give a rationale on why pg_archivebackup is retired, and what it should be replaced with, in case valid use-cases for it are still present. Michael -- Michael Banck Projektleiter / Senior Berater Tel.: +49 2166 9901-171 Fax: +49 2166 9901-100 Email: michael.ba...@credativ.de credativ GmbH, HRB Mönchengladbach 12080 USt-ID-Nummer: DE204566209 Trompeterallee 108, 41189 Mönchengladbach Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer Unser Umgang mit personenbezogenen Daten unterliegt folgenden Bestimmungen: https://www.credativ.de/datenschutz
