On Wed, Oct 21, 2020 at 4:20 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > On Wed, Oct 21, 2020 at 3:18 PM Bharath Rupireddy > <bharath.rupireddyforpostg...@gmail.com> wrote: > > > > 17. Remove extra lines after #define IsHeaderLine() > > (cstate->header_line && cstate->cur_lineno == 1) in copy.h > > > > I missed one comment: > > 18. I think we need to treat the number of parallel workers as an > integer similar to the parallel option in vacuum. > > postgres=# copy t1 from stdin with(parallel '1'); <<<<< - we > should not allow this. > Enter data to be copied followed by a newline. > > postgres=# vacuum (parallel '1') t1; > ERROR: parallel requires an integer value >
I have made the behavior the same as vacuum. This is addressed in v9 patch shared at [1]. [1] - https://www.postgresql.org/message-id/caldanm1caonkfdn6k72dsirpgqngvwxql7tjeihz58opnp9...@mail.gmail.com Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
