On Tue, Oct 20, 2020 at 12:25:48PM -0400, Tom Lane wrote:
> Alvaro Herrera <alvhe...@alvh.no-ip.org> writes:
> > On 2020-Oct-18, Tom Lane wrote:
> >> It doesn't really seem sane to me to support two different build
> >> environments for thread_test, especially when one of them is so
> >> little-used that it can be broken for years before we notice.
> >> So I'd be inclined to rip out the Makefile and just consider
> >> that thread_test.c is *only* meant to be used by configure.
> >> If we wish to resurrect the standalone build method, we could
> >> probably do so by adding LIBS to the Makefile's link command
> >> ... but what's the point, and what will keep it from getting
> >> broken again later?
> 
> > Standalone usage of that program is evidently non-existant, so +1 for
> > removing the Makefile and just keep the configure compile path for it.
> 
> I concluded that if thread_test.c will only be used by configure,
> then we should stick it under $(SRCDIR)/config/ and nuke the
> src/test/thread/ subdirectory altogether.  See attached.

Sounds good.

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee



Reply via email to