On Tue, Oct 20, 2020 at 9:57 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Mon, Oct 19, 2020 at 8:55 PM Heikki Linnakangas <hlinn...@iki.fi> wrote: > > It's probably true that there's no performance gain from initializing > > them more lazily. But the reasoning and logic around the initialization > > is complicated. After tracing through various path through the code, I'm > > convinced enough that it's correct, or at least these patches didn't > > break it, but I still think some sort of lazy initialization on first > > use would make it more readable. Or perhaps there's some other > > refactoring we could do. > > So the other patch I have mentioned is about lazy initialization of > the ResultRelInfo itself, not the individual fields, but maybe with > enough refactoring we can get the latter too.
So, I tried implementing a lazy-initialization-on-first-access approach for both the ResultRelInfos themselves and some of the individual fields of ResultRelInfo that don't need to be set right away. You can see the end result in the attached 0003 patch. This slims down ExecInitModifyTable() significantly, both in terms of code footprint and the amount of work that it does. 0001 fixes a thinko of the recent commit 1375422c782 that I discovered when debugging a problem with 0003. 0002 is for something I have mentioned upthread. ForeignScanState.resultRelInfo cannot be set in ExecInit* stage as it's done now, because with 0003, child ResultRelInfos will not have been added to es_result_relations during that stage. -- Amit Langote EDB: http://www.enterprisedb.com
v1-0002-Initialize-ForeignScanState.resultRelInfo-in-Exec.patch
Description: Binary data
v1-0001-Fix-a-thinko-of-1375422c782.patch
Description: Binary data
v1-0003-Initialize-result-relation-information-lazily.patch
Description: Binary data
