On Fri, Oct 16, 2020 at 2:00 AM Andres Freund <and...@anarazel.de> wrote: > > On 2020-10-15 12:38:49 +0530, Amit Kapila wrote: > > On Wed, Oct 14, 2020 at 4:51 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > > > On Wed, Oct 14, 2020 at 4:12 PM Amit Kapila <amit.kapil...@gmail.com> > > > wrote: > > > > > > > > > > > > Thanks for the tests. The latest patch looks mostly good to me. I have > > > > made minor changes to the patch (a) changed the order where the new > > > > message is placed at one place to make it consistent with other > > > > places, (b) as discussed offlist, removed the extra increment to a > > > > local variable in ReorderBufferRestoreChange, (c) ran pgindent. > > > > > > > > See the attached and let me know what do you think? > > > > > > The changes look good to me. > > > > > > > Pushed! > > Awesome - it's great to see this problem finally addressed! >
Thanks, I'm glad that you liked it. -- With Regards, Amit Kapila.
