On Sun, Oct 11, 2020 at 08:35:13PM +0200, Christoph Berg wrote: > Re: Tom Lane >> Hmm, I'd argue for a back-patch. The issue of modern compilers >> warning about the incorrect code will apply to all supported branches. >> Moreover, even if we don't use these code paths today, who's to say >> that someone won't back-patch a bug fix that requires them? I do not >> think it's unreasonable to expect these functions to work well in >> all branches that have them. > > Or remove them. (But fixing seems better.)
The patch is not that invasive, so just fixing back-branches sounds like a good idea to me. My 2c. -- Michael
signature.asc
Description: PGP signature