On Wed, Jun 24, 2020 at 11:51 AM Robert Haas <robertmh...@gmail.com> wrote: > Thanks for the review. v2 attached, hopefully fixing the compilation > issue you mentioned.
Tushar Ahuja reported to me off-list that my basebackup refactoring patch set was changing whether or not the following message appeared: NOTICE: WAL archiving is not enabled; you must ensure that all required WAL segments are copied through other means to complete the backup That patch set includes this patch, and the reason for the behavior difference turned out to be that I had gotten an if-test that is part of this patch backwards. Here is v3, fixing that. It is a little disappointing that this mistake didn't cause any existing regression tests to fail. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
v3-0001-Flexible-options-for-BASE_BACKUP-and-CREATE_REPLI.patch
Description: Binary data