On Tue, 6 Oct 2020 at 17:56, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Oct 6, 2020 at 9:34 AM Masahiko Sawada > <masahiko.saw...@2ndquadrant.com> wrote: > > > > Looking at pgstat_reset_replslot_counter() in the v8 patch, even if we > > pass a physical slot name to pg_stat_reset_replication_slot() a > > PgStat_MsgResetreplslotcounter is sent to the stats collector. I’m > > okay with not raising an error but maybe we can have it not to send > > the message in that case. > > > > makes sense, so changed accordingly. >
Thank you for updating the patch! Both patches look good to me. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
