Hello!
I am trying to help for Project PostgreSQL. Check source code PostgreSQL by
PVS-Studio.
PVS-Studio have many issue, but some issue is interesting.
nbtpage.c:356 <http://localhost/sources/nbtpage.c_24.html#ln356> *High* V547
<https://www.viva64.com/en/w/v547/> Expression 'metad->btm_root != 0' is
always false.
Source file src/backend/access/nbtree/nbtpage.c
if (metad->btm_root == P_NONE)
{
Page metapg;
/* If access = BT_READ, caller doesn't want us to create root yet */
if (access == BT_READ)
{
_bt_relbuf(rel, metabuf);
return InvalidBuffer;
}
/* trade in our read lock for a write lock */
_bt_unlockbuf(rel, metabuf);
_bt_lockbuf(rel, metabuf, BT_WRITE);
/*
* Race condition: if someone else initialized the metadata between
* the time we released the read lock and acquired the write lock, we
* must avoid doing it again.
*/
if (metad->btm_root != P_NONE)
↑ V547 <https://www.viva64.com/en/w/v547/> Expression 'metad->btm_root !=
0' is always false.
--
С уважением, Антон Пацев.
Best regards, Anton Patsev.
