On Tue, Oct 6, 2020 at 11:20 AM Fujii Masao <masao.fu...@oss.nttdata.com> wrote: > > >> > >> Probably we can also replace sigHupHandler() in syslogger.c with > >> SignalHandlerForConfigReload()? This would be separate patch, though. > >> > > > > +1 to replace sigHupHandler() with SignalHandlerForConfigReload() as > > the latch and the functionality are pretty much the same. > > > > WalReceiverMai(): I think we can also replace WalRcvShutdownHandler() > > with SignalHandlerForShutdownRequest() because walrcv->latch point to > > &MyProc->procLatch which in turn point to MyLatch. > > > > Thoughts? If okay, we can combine these into a single patch. I will > > post an updated patch soon. > > +1 Or it's also ok to make each patch separately. > Anyway, thanks! >
Thanks. +1 to have separate patches. I will post two separate patches for autoprewarm and WalRcvShutdownHandler for further review. The other two patches can be for startup.c and syslogger.c. With Regards, Bharath Rupireddy. EnterpriseDB: http://www.enterprisedb.com
