Hi I found the function SPI_connect() has only one return value(SPI_OK_CONNECT). But I also found that some places check the return value of SPI_connect() like the following:
if (SPI_connect() != SPI_OK_CONNECT) elog(ERROR, "SPI_connect failed"); Is it necessary to check the return value of SPI_connect() ? And in doc https://www.postgresql.org/docs/13/spi-spi-connect.html It also says SPI_connect() can return SPI_ERROR_CONNECT on error. May be we can make "int SPI_connect()" => "void SPI_connect()" and fix the doc ? Best regards, houzj