On Wed, Sep 23, 2020 at 9:16 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > LGTM.
Committed. Thomas, with respect to your part of this patch set, I wonder if we can make the functions that you're using to write tests safe enough that we could add them to contrib/old_snapshot and let users run them if they want. As you have them, they are hedged around with vague and scary warnings, but is that really justified? And if so, can it be fixed? It would be nicer not to end up with two loadable modules here, and maybe the right sorts of functions could even have some practical use. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company