On Mon, Aug 17, 2020 at 05:47:13PM +0200, Drouvot, Bertrand wrote: > I think it's good to guarantee that we'll always see the same piece of > information (should a new RM desc() be created in the future for example), > even if it could lead to some information overlap in some cases.
> I am ok too, but I am also not sure that errcontext is the right place for > that. Hmm. I still think that knowing at least about a FPW could be an interesting piece of information even here. Anyway, instead of copying a logic that exists already in xlog_outrec(), why not moving the block information print into a separate routine out of the WAL_DEBUG section, and just reuse the same format for the context of the redo error callback? That would also be more consistent with what we do in pg_waldump where we don't show the fork name of a block when it is on a MAIN_FORKNUM. And this would avoid a third copy of the same logic. If we add the XID, previous LSN and the record length on the stack of what is printed, we could just reuse the existing routine, still that's perhaps too much information displayed. -- Michael
signature.asc
Description: PGP signature
