On Mon, Sep 21, 2020 at 6:58 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Sep 21, 2020 at 6:27 PM Ashutosh Sharma <ashu.coe...@gmail.com> wrote: > > > > Thanks Dilip for the patch. AFAIU, the fix looks good. One small comment: > > > > Thanks Ashutosh and Dilip for working on this. I'll look into it in a > day or two. >
Just a thought: Should we change the sequence of these #define in src/include/replication/logicalproto.h? #define LOGICALREP_PROTO_MIN_VERSION_NUM 1 #define LOGICALREP_PROTO_STREAM_VERSION_NUM 2 #define LOGICALREP_PROTO_VERSION_NUM 1 #define LOGICALREP_PROTO_MAX_VERSION_NUM LOGICALREP_PROTO_STREAM_VERSION_NUM I would have changed above to something like this: #define LOGICALREP_PROTO_VERSION_NUM 1 #define LOGICALREP_PROTO_STREAM_VERSION_NUM 2 #define LOGICALREP_PROTO_MIN_VERSION_NUM LOGICALREP_PROTO_VERSION_NUM #define LOGICALREP_PROTO_MAX_VERSION_NUM LOGICALREP_PROTO_STREAM_VERSION_NUM -- With Regards, Ashutosh Sharma EnterpriseDB:http://www.enterprisedb.com
