Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > On 2020-09-07 01:46, Tom Lane wrote: >> I reviewed the 0002 patch, finding one bug (in int8_sum)
> Ouch, no test coverage. Should we perhaps remove this function, since > it's obsolete and unused? I don't feel a need to. >> and a few >> more calls of int8_numeric that could be converted. I think the >> attached updated version is committable, and I'd recommend going >> ahead with that regardless of the rest of this. I hadn't realized >> how many random calls of int8_numeric and int4_numeric we'd grown, >> but there are a lot, so this is nice cleanup. > Yes, please go ahead with it. It's your patch, I figured you'd want to commit it. regards, tom lane