On Tue, Sep 01, 2020 at 11:48:30AM -0400, Alvaro Herrera wrote: > On 2020-Sep-01, Justin Pryzby wrote: >> The question isn't whether to use a parenthesized option list. I realized >> that >> long ago (even though Alexey didn't initially like it). Check 0002, which >> gets >> rid of "bool concurrent" in favour of stmt->options&REINDEXOPT_CONCURRENT. > > Ah! I see, sorry for the noise. Well, respectfully, having a separate > boolean to store one option when you already have a bitmask for options > is silly.
Yeah, I am all for removing "concurrent" from ReindexStmt, but I don't think that the proposed 0002 is that, because it is based on the assumption that we'd want more than just boolean-based options in those statements, and this case is not justified yet except if it becomes possible to enforce tablespaces. At this stage, I think that it is more sensible to just update gram.y and add a REINDEXOPT_CONCURRENTLY. I also think that it would also make sense to pass down "options" within ReindexIndexCallbackState() (for example imagine a SKIP_LOCKED for REINDEX). -- Michael
signature.asc
Description: PGP signature
