Hi, On 2020-08-15 13:44:34 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > One thing is that some here are actively against manually adding entries > > to typedefs.list. > > I've been of the opinion that it's pointless to do so under the current > regime where (a) only a few people do that and (b) we only officially > re-indent once a year anyway. When I want to manually run pgindent, > I always pull down a fresh typedefs.list from the buildfarm, which is > reasonably up-to-date regardless of what people added or didn't add, > and then add any new typedefs from my current patch to that out-of-tree > copy.
Well, properly indenting new code still is worthwhile. And once you go through the trouble of adding the typedefs locally, I don't really see the reason not to also include them in the commit. Sure it'll not help much with tree-wide re-indents, but with individual files it can still make life less painful. Greetings, Andres Freund
