On Mon, Aug 3, 2020 at 11:02 AM Mark Dilger <mark.dil...@enterprisedb.com> wrote: > I was trying to limit unnecessary whitespace changes. s/ereport/econfess/ > leaves the function name nearly the same length such that the following lines > of indented error text don't usually get moved by pgindent. Given the > unpopularity of the name, it's not worth it, so I'll go with Robert's > report_corruption, instead.
Yeah, that's not really a good reason for something like that. I think what you should do is drop the nbtree portion of this for now; the length of the name then doesn't even matter at all, because all the code in which this is used will be new code. Even if we were churning existing code, mechanical stuff like this isn't really a huge problem most of the time, but there's no need for that here. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
