On 2020/07/20 13:48, Fujii Masao wrote:
On 2020/07/17 20:24, David Steele wrote:
On 7/17/20 5:11 AM, Fujii Masao wrote:
On 2020/07/14 20:30, David Steele wrote:
On 7/14/20 12:00 AM, Fujii Masao wrote:
The patch was no longer applied cleanly because of recent commit.
So I updated the patch. Attached.
Barring any objection, I will commit this patch.
This doesn't look right:
+ the <xref linkend="guc-wal-keep-size"/> most recent megabytes
+ WAL files plus one WAL file are
How about:
+ <xref linkend="guc-wal-keep-size"/> megabytes of
+ WAL files plus one WAL file are
Thanks for the comment! Isn't it better to keep "most recent" part?
If so, what about either of the followings?
1. <xref linkend="guc-wal-keep-size"/> megabytes of WAL files plus
one WAL file that were most recently generated are kept all time.
2. <xref linkend="guc-wal-keep-size"/> megabytes + <xref
linkend="guc-wal-segment-size"> bytes
of WAL files that were most recently generated are kept all time.
"most recent" seemed implied to me, but I see your point.
How about:
+ the most recent <xref linkend="guc-wal-keep-size"/> megabytes of
+ WAL files plus one additional WAL file are
I adopted this and pushed the patch. Thanks!
Also we need to update the release note for v13. What about adding the
following?
------------------------------------
Rename configuration parameter wal_keep_segments to wal_keep_size.
This allows how much WAL files to retain for the standby server, by bytes
instead of the number of files.
If you previously used wal_keep_segments, the following formula will give you
an approximately equivalent setting:
wal_keep_size = wal_keep_segments * wal_segment_size (typically 16MB)
------------------------------------
Patch attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
diff --git a/doc/src/sgml/release-13.sgml b/doc/src/sgml/release-13.sgml
index 22363a186b..c3698c1401 100644
--- a/doc/src/sgml/release-13.sgml
+++ b/doc/src/sgml/release-13.sgml
@@ -209,6 +209,28 @@ Author: Fujii Masao <fu...@postgresql.org>
<listitem>
<!--
+Author: Fujii Masao <fu...@postgresql.org>
+2020-07-20 [f5dff45962] Rename wal_keep_segments to wal_keep_size.
+-->
+
+ <para>
+ Rename configuration parameter <varname>wal_keep_segments</varname>
+ to <xref linkend="guc-wal-keep-size"/> (Fujii Masao)
+ </para>
+
+ <para>
+ This allows how much WAL files to retain for the standby server,
+ to be specified by bytes instead of the number of files. If you
+ previously used <varname>wal_keep_segments</varname>,
+ the following formula will give you an approximately equivalent setting:
+<programlisting>
+wal_keep_size = wal_keep_segments * wal_segment_size (typically 16MB)
+</programlisting>
+ </para>
+ </listitem>
+
+ <listitem>
+<!--
Author: Tom Lane <t...@sss.pgh.pa.us>
2020-03-05 [84eca14bc] Remove ancient hacks to ignore certain opclass names in
-->
