Hi Takamichi-san, On Tue, Jul 14, 2020 at 8:26 PM osumi.takami...@fujitsu.com <osumi.takami...@fujitsu.com> wrote: > > Amit san > > > Hello. I've tested your patch.
Thanks for that. > Just small comment about your patch. > I felt the test you added in update.sql could be simpler or shorter in other > form. > Excuse me if I say something silly. > It's because I supposed you can check the bug is prevented without > definitions of both a function and its trigger for this case. Neither of them > is essentially connected with the row movement between source partition and > destination partition and can be replaced by simpler expression ? Well, it's true that the function and the trigger have nothing to do with the main bug, but it's often good to be sure that the bug-fix isn't breaking cases where they are present and have visible effect. -- Amit Langote EnterpriseDB: http://www.enterprisedb.com
