On Tue, May 12, 2020 at 8:56 PM Laurenz Albe <laurenz.a...@cybertec.at> wrote:
> On Tue, 2020-05-12 at 18:09 -0700, David G. Johnston wrote: > > Redirecting to -hackers for visibility. I feel there needs to be > something done here, even if just documentation (a bullet in the usage > notes section - and a code comment update for the macro) > > pointing this out and not changing any behavior. > > Since "to_date" is an Oracle compatibility function, here is what Oracle > 18.4 has to say to that: > > SQL> SELECT to_date('0000', 'YYYY') FROM dual; > SELECT to_date('0000', 'YYYY') FROM dual > * > ERROR at line 1: > ORA-01841: (full) year must be between -4713 and +9999, and not be 0 > > Attached is a concrete patch (back-patchable hopefully) documenting the current reality. As noted in the patch commit message (commentary really): make_timestamp not agreeing with make_date on how to handle negative years should probably just be fixed - but that is for someone else to handle. Whether to actually change the behavior of to_date is up for debate though I would presume it would not be back-patched. David J.
v1-001-to-date-behavior-in-bc-bug16419.patch
Description: Binary data