On Mon, Jul 13, 2020 at 10:47 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > On Sun, Jul 12, 2020 at 9:56 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > On Mon, Jul 6, 2020 at 11:43 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > > > On Mon, Jul 6, 2020 at 11:31 AM Amit Kapila <amit.kapil...@gmail.com> > > > wrote: > > > > > > > > > > > > > 10. I have got the below failure once. I have not investigated > > > > > > this > > > > > > in detail as the patch is still under progress. See, if you have > > > > > > any > > > > > > idea? > > > > > > # Failed test 'check extra columns contain local defaults' > > > > > > # at t/013_stream_subxact_ddl_abort.pl line 81. > > > > > > # got: '2|0' > > > > > > # expected: '1000|500' > > > > > > # Looks like you failed 1 test of 2. > > > > > > make[2]: *** [check] Error 1 > > > > > > make[1]: *** [check-subscription-recurse] Error 2 > > > > > > make[1]: *** Waiting for unfinished jobs.... > > > > > > make: *** [check-world-src/test-recurse] Error 2 > > > > > > > > > > Even I got the failure once and after that, it did not reproduce. I > > > > > have executed it multiple time but it did not reproduce again. Are > > > > > you able to reproduce it consistently? > > > > > > > > > ... .. > > > > I think the reason for the failure is that we are not setting > > remote_final_lsn, in the streaming mode. I have put multiple logs and > > executed in log and from logs it appeared that some of the logical wal > > did not get replayed due to below check in > > should_apply_changes_for_rel. > > return (rel->state == SUBREL_STATE_READY || (rel->state == > > SUBREL_STATE_SYNCDONE && rel->statelsn <= remote_final_lsn)); > > > > I still need to do the detailed analysis that why does this fail in > > some cases, basically, most of the time the rel->state is > > SUBREL_STATE_READY so this check passes but whenever the state is > > SUBREL_STATE_SYNCDONE it failed because we never update > > remote_final_lsn. I will try to set this value in > > apply_handle_stream_commit and see whether it ever fails or not. > > I have verified that after setting the remote_final_lsn in the > apply_handle_stream_commit, I don't see that regression failure in > over 70 runs whereas without that change it failed 6 times in 50 runs. >
Your analysis and fix seem correct to me. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
