Thomas Munro <thomas.mu...@gmail.com> writes: > On Wed, Jul 1, 2020 at 5:49 AM Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> - More test coverage is needed. Surprisingly, there wasn't actually any >> test AFAICT that just creates and SQL function and runs it. Most of >> that code is tested incidentally, but there is very little or no >> targeted testing of this functionality.
> FYI cfbot showed a sign of some kind of error_context_stack corruption > while running "DROP TABLE functest3 CASCADE;". BTW, it occurs to me after answering bug #16534 that contrib/earthdistance's SQL functions would be great candidates for this new syntax. Binding their references at creation time is really exactly what we want. I still feel that we can't just replace the existing implementation, though, as that would kill too many use-cases where late binding is helpful. regards, tom lane