On 7/8/20 5:26 PM, Tom Lane wrote: > > However ... I put in a test case to try to expose this failure, and > our Windows buildfarm critters remain perfectly happy. So what's up > with that? After some digging around, I believe the reason is that > PostgresNode::psql is stripping the \r from pg_current_logfile()'s > result, here: > > $$stdout =~ s/\r//g if $TestLib::windows_os; > > I'm slightly tempted to extend the test case by verifying on the > server side that the result ends in ".log" with no extra characters. > More generally, I wonder if the above behavior is really a good idea. > It seems to have been added in commit 33f3bbc6d as a hack to avoid > having to think too hard about mingw's behavior, but now I wonder if > it isn't masking other bugs too. At the very least I think we ought > to tighten the coding to > > $$stdout =~ s/\r\n/\n/g if $TestLib::windows_os; > > so that it won't strip carriage returns at random. >
Seems reasonable. If we rip it out completely we'll have to find all the places it breaks and fix them. And we'll almost certainly get new breakage. If it's hiding a real bug we'll have to do that, but I'd be reluctant unless there's actual proof. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
