On Tue, Jun 30, 2020 at 10:11:04AM +0200, Peter Eisentraut wrote: > On 2020-05-04 07:50, Michael Paquier wrote: >> Yeah. The years have visibly proved that the README had updates when >> it came to the general descriptions of the libpqwalreceiver interface, >> but that we had better consolidate the header to give some >> documentation to whoever plays with this interface. Attached is a >> patch to address all that, where I simplified the README and added >> some description to all the callbacks. Thoughts are welcome. I'll >> add that to the next CF. Now I don't see any actual problems in >> getting that on HEAD before v13 forks. But let's gather more opinions >> first. > > This patch looks good to me.
Thanks for the review, Peter. After an extra read, the description of walrcv_create_slot_fn was not complete (missed the end of the sentence to say that NULL is returned for a physical slot) and had a grammar mistake. So I have fixed this part, and applied the patch on HEAD. Perhaps things could be improved further more, so if anybody has any suggestion please feel free. -- Michael
signature.asc
Description: PGP signature
