On Wed, Jul 1, 2020 at 4:29 PM Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> wrote: > > changes look good to me.
Thanks for looking at the patch. > > one comment: instead of having block variables onexit, in the while > loops in shmem_exit, can we have a single local variable defined at > the start of the shmem_exit function > and reuse them in the while loops? same comment for onexit block > variable in proc_exit_prepare() function. > If you are worried about the declaration and initialization of the variable will happen with every loop cycle then you shouldn't because that happens only once before the loop-block is entered. Regards, Amul
