On 2020/06/18 3:04, Alvaro Herrera wrote:
I think passing the slot name when the slot is also passed is useless and wasteful; it'd be better to pass NULL for the name and ignore the strcmp() in that case -- in fact I suggest to forbid passing both name and slot. (Any failure there would risk raising an error during checkpoint, which is undesirable.)
Sounds reasonable.
So I propose the following tweaks to your patch, and otherwise +1.
Thanks for the patch! It looks good to me. Barring any objections, I will commit the patches in the master and v13 branches later. Regards, -- Fujii Masao Advanced Computing Technology Center Research and Development Headquarters NTT DATA CORPORATION
