On Tue, 2 Jun 2020 at 14:50, Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Tue, Jun 2, 2020 at 10:22 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Tue, Jun 2, 2020 at 9:10 AM Masahiko Sawada > > <masahiko.saw...@2ndquadrant.com> wrote: > > > > > > > > Please find attached patch. > > > > > > > On a quick look, it seems fine but I will look in more detail and let > > you know if I have any feedback. > > > > I am not sure if we need to add "Logical decoding plugins may > optionally emit tracking message." as the stats behavior should be the > same for decoding plugin and logical replication. Apart from removing > this line, I have made a few other minor changes, see what you think > of attached? >
I'm okay with removing that sentence. The patch looks good to me. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
