At Tue, 26 May 2020 09:10:40 -0400, Jeff Janes <jeff.ja...@gmail.com> wrote in > In postgresql.conf, it says: > > #max_slot_wal_keep_size = -1 # measured in bytes; -1 disables > > I don't know if that is describing the dimension of this parameter or the > units of it, but the default units for it are megabytes, not individual > bytes, so I think it is pretty confusing.
Agreed. It should be a leftover at the time the unit was changed (before committed) to MB from bytes. The default value makes the confusion worse. Is the following works? #max_slot_wal_keep_size = -1 # in MB; -1 disables regards. -- Kyotaro Horiguchi NTT Open Source Software Center
>From 0bd9a7360caaf8a31d71ba6392d9e4b7496a9c02 Mon Sep 17 00:00:00 2001 From: Kyotaro Horiguchi <horikyoga....@gmail.com> Date: Wed, 27 May 2020 10:42:24 +0900 Subject: [PATCH] Change a comment in postgresql.conf.sample Fix a lame comment for max_slot_wal_keep_size so that it suggests the unit for the value. --- src/backend/utils/misc/postgresql.conf.sample | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/utils/misc/postgresql.conf.sample b/src/backend/utils/misc/postgresql.conf.sample index 995b6ca155..43340eee71 100644 --- a/src/backend/utils/misc/postgresql.conf.sample +++ b/src/backend/utils/misc/postgresql.conf.sample @@ -289,7 +289,7 @@ #max_wal_senders = 10 # max number of walsender processes # (change requires restart) #wal_keep_segments = 0 # in logfile segments; 0 disables -#max_slot_wal_keep_size = -1 # measured in bytes; -1 disables +#max_slot_wal_keep_size = -1 # in MB; -1 disables #wal_sender_timeout = 60s # in milliseconds; 0 disables #max_replication_slots = 10 # max number of replication slots -- 2.18.2
