On Tue, 2020-05-26 at 21:15 +0200, Tomas Vondra wrote: > Yeah. I agree prefetching is definitely out of v13 scope. It might be > interesting to try how useful would it be, if you're willing to spend > some time on a prototype.
I think a POC would be pretty quick; I'll see if I can hack something together. > I think it's pretty much ready to go. Committed with max of 128 preallocated blocks. Minor revisions. > > As for the tlist fix, I think that's mostly ready too - the one thing > we > should do is probably only doing it for AGG_HASHED. For AGG_SORTED > it's > not really necessary. Melanie previously posted a patch to avoid spilling unneeded columns, but it introduced more code: https://www.postgresql.org/message-id/caakru_aefesv+ukqwqu+ioenoil2lju9diuh9br8mbyxuz0...@mail.gmail.com and it seems that Heikki also looked at it. Perhaps we should get an acknowledgement from one of them that your one-line change is the right approach? Regards, Jeff Davis
