Em qua., 13 de mai. de 2020 às 11:46, Fujii Masao < masao.fu...@oss.nttdata.com> escreveu:
> > > On 2020/05/13 23:26, Tom Lane wrote: > > Fujii Masao <masao.fu...@oss.nttdata.com> writes: > >> On 2020/05/13 17:21, Tomas Vondra wrote: > >>> On Wed, May 13, 2020 at 04:10:30PM +0900, Fujii Masao wrote: > >>>> Also I found another minor issue; SLRUStats has not been initialized > to 0 > >>>> and which could update the counters unexpectedly. Attached patch fixes > >>>> this issue. > > > >> Pushed both. Thanks! > > > > Why is that necessary? A static variable is defined by C to start off > > as zeroes. > > Because SLRUStats is not a static variable. No? > IMHO, BgWriterStats have the same problem, shouldn't the same be done? /* Initialize BgWriterStats to zero */ MemSet(&BgWriterStats, 0, sizeof(BgWriterStats)); /* Initialize SLRU statistics to zero */ memset(&SLRUStats, 0, sizeof(SLRUStats)); regards, Ranier Vilela
