On Sun, May 10, 2020 at 07:08:03PM -0300, Euler Taveira wrote: > I attached a patch with the described solution. I also included a test that > covers this scenario.
- Assert(RelationGetReplicaIndex(rel) == RelationGetRelid(idxrel)); + Assert(GetRelationIdentityOrPK(rel) == RelationGetRelid(idxrel)); Not much a fan of adding a routine to relcache.c to do the work of two routines already present, so I think that we had better add an extra condition based on RelationGetPrimaryKeyIndex, and give up on GetRelationIdentityOrPK() in execReplication.c. Wouldn't it also be better to cross-check the replica identity here depending on if RelationGetReplicaIndex() returns an invalid OID or not? -- Michael
signature.asc
Description: PGP signature
