On Thu, May 7, 2020 at 08:29:55AM +0200, Fabien COELHO wrote: > > Hello Bruce, > > > > > > * "DOCUMENT THE DEFAULT GENERATION METHOD" > > > > > => The default is still to generate data client-side. > > > > > > > > My point is that the docs are not clear about this. > > > > > > Indeed. > > > > > > > Can you fix it? > > > > > > Sure. Attached patch adds an explicit sentence about it, as it was only > > > hinted about in the default initialization command string, and removes a > > > spurious empty paragraph found nearby. > > > > Thanks, patch applied. > > Ok. > > You might remove the "DOCUMENT THE DEFAULT…" in the release note.
Oh, yes, of course. > I'm wondering about the commit comment: "Reported-by: Fabien COELHO", > actually you reported it, not me! Uh, kind of, yeah, but via email, you did. ;-) > After looking again at the release notes, I do really think that significant > documentation changes do not belong to the "Source code" section but should > be in separate "Documentation" section, and that more items should be listed > there, because they represent a lot of not-so-fun work, especially Tom's > restructuration of tables, and possibly others. Uh, can someone else give an opinion on this? I am not sure how hard or un-fun an item is should be used as criteria. > About pgbench, ISTM that d37ddb745be07502814635585cbf935363c8a33d is worth > mentionning because it is a user-visible change. Uh, that is not usually something I mention because, like error message changes, it is nice, but few people need to know about it before they see it. -- Bruce Momjian <br...@momjian.us> https://momjian.us EnterpriseDB https://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +
