On 2020-04-19 09:37:08 -0400, Tom Lane wrote: > Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: > > The HEAPDEBUGALL define has been broken since PG12 due to tableam > > changes. Should we just remove this? It doesn't look very useful. > > It's been around since Postgres95. > > If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL > > (which still compiles correctly). Would we want to keep that? > > +1 for removing both. There are a lot of such debug "features" > in the code, and few of them are worth anything IME.
Belatedly: +many
