On Wed, Apr 22, 2020 at 9:31 PM Erik Rijkers <e...@xs4all.nl> wrote: > > On 2020-04-22 16:49, Dilip Kumar wrote: > > On Tue, Apr 21, 2020 at 5:30 PM Dilip Kumar <dilipbal...@gmail.com> > > wrote: > >> > >> > > >> > (by the way: this build's regression tests 'ddl', 'toast', and > >> > 'spill' fail) > >> > >> Yeah, this is a. known issue, actually, while streaming the > >> transaction the output message is changed. I have a plan to work on > >> this part. > > > > I have fixed this part. Basically, now, I have created a separate > > function to get the streaming changes > > 'pg_logical_slot_get_streaming_changes'. So the default function > > pg_logical_slot_get_changes will work as it is and test decoding test > > cases will not fail. > > The 'ddl' one is apparently not quite fixed - I get this in (cd > contrib; make check)' (in both assert-enabled and non-assert-enabled > build)
Can you send me the contrib/test_decoding/regression.diffs file? > grep -A7 -B7 make.check_contrib.out: > > contrib/make.check_contrib.out-============== initializing database > system ============== > contrib/make.check_contrib.out-============== starting postmaster > ============== > contrib/make.check_contrib.out-running on port 64464 with PID 9175 > contrib/make.check_contrib.out-============== creating database > "contrib_regression" ============== > contrib/make.check_contrib.out-CREATE DATABASE > contrib/make.check_contrib.out-ALTER DATABASE > contrib/make.check_contrib.out-============== running regression test > queries ============== > contrib/make.check_contrib.out:test ddl ... > FAILED 840 ms > contrib/make.check_contrib.out-test xact ... ok > 24 ms > contrib/make.check_contrib.out-test rewrite ... ok > 187 ms > contrib/make.check_contrib.out-test toast ... ok > 851 ms > contrib/make.check_contrib.out-test permissions ... ok > 26 ms > contrib/make.check_contrib.out-test decoding_in_xact ... ok > 31 ms > contrib/make.check_contrib.out-test decoding_into_rel ... ok > 25 ms > contrib/make.check_contrib.out-test binary ... ok > 12 ms > > Otherwise patches apply and build OK so will go run some tests... Thanks -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
