On Tue, Apr 21, 2020 at 2:54 AM Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > Proposed fix is attached. Spotted by Konstantin Knizhnik, > reproduction case and fix from me.
I wonder if we should fix btree_xlog_unlink_page() instead of amcheck. We already know that its failure to be totally consistent with the primary causes problems for backwards scans -- this problem can be fixed at the same time: https://postgr.es/m/cantu0ohkr-evawbpzju54v8ecotqjjyyp3pq_sgobtrgxwh...@mail.gmail.com We'd probably still use your patch for the backbranches if we went this way. What do you think? -- Peter Geoghegan