On 4/9/20 2:26 PM, Peter Eisentraut wrote: > On 2020-04-09 19:47, Robert Haas wrote: >> On Thu, Apr 9, 2020 at 11:44 AM Andrew Dunstan >> <andrew.duns...@2ndquadrant.com> wrote: >>> We currently only run perlcritic at severity level 5, which is fairly >>> permissive. I'd like to reduce that, ideally to, say, level 3, which is >>> what I use for the buildfarm code. >>> >>> But let's start by going to severity level 4. >> >> I continue to be skeptical of perlcritic. I think it complains about a >> lot of things which don't matter very much. We should consider whether >> the effort it takes to keep it warning-clean has proportionate >> benefits. > > Let's see what the patches look like. At least some of the warnings > look reasonable, especially in the sense that they are things casual > Perl programmers might accidentally do wrong.
OK, I'll prep one or two. I used to be of Robert's opinion, but I've come around some on it. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
