On Fri, Mar 27, 2020 at 5:03 AM Justin Pryzby <pry...@telsasoft.com> wrote: >
Now that the main patch is committed, I have reviewed the other two patches. v37-0002-Drop-reltuples 1. @@ -2289,11 +2289,10 @@ vacuum_one_index(Relation indrel, IndexBulkDeleteResult **stats, /* Do vacuum or cleanup of the index */ if (lvshared->for_cleanup) - lazy_cleanup_index(indrel, stats, lvshared->reltuples, - lvshared->estimated_count, vacrelstats); + lazy_cleanup_index(indrel, stats, vacrelstats); else lazy_vacuum_index(indrel, stats, dead_tuples, - lvshared->reltuples, vacrelstats); + vacrelstats); I don't think the above change is correct. How will vacrelstats have correct values when vacuum_one_index is called via parallel workers (via parallel_vacuum_main)? The v37-0003-Avoid-some-calls-to-RelationGetRelationName.patch looks good to me. I have added the commit message in the patch. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
v38-0001-Avoid-some-calls-to-RelationGetRelationName-and-.patch
Description: Binary data
