On 11/6/19 12:48 AM, Fabien COELHO wrote:

Hello Andres,

Attached v3 shorten some lines and adds "append_tablespace".

A v4 which just extends the patch to newly added 'G'.

I'd prefer not to expand the use of pqexpbuffer in more places, and
instead rather see this use StringInfo, now that's also available to
frontend programs.

Franckly, one or the other does not matter much to me.

FWIW, I agree with Andres with regard to using StringInfo.

Also, the changes to executeStatementExpect() and adding executeStatement() do not seem to fit in with the purpose of this patch.

Regards,
--
-David
da...@pgmasters.net


Reply via email to