On Tue, Mar 24, 2020 at 6:16 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Mon, Mar 9, 2020 at 11:07 PM Andres Freund <and...@anarazel.de> wrote: > > > > On 2020-03-07 11:15:27 +0530, Dilip Kumar wrote: > > > IMHO, if we conclude that because there is no performance gain so we > > > don't want to add one extra path in the code then we might want to > > > remove that TODO from the code so that we don't spend time for > > > optimizing this in the future. > > > > +1 > > > > Dilip, are you planning to do more tests for this? Anyone else wants > to do more tests? If not, based on current results, we can remove that > TODO and in future, if someone comes with a test case to show benefit > for adding fastpath, then we can consider the patch proposed by Dilip.
IMHO, I have tried the best case but did not see any performance gain so I am not planning to test this further. I have attached the patch for removing the TODO. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
0001-Remove-TODO-comments-for-fast-path.patch
Description: Binary data
