On Mon, Mar 23, 2020 at 1:05 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > ... all plan types that use only one child use the outer one. They > > could use either, as long as it does that consistently, I think. > > Yeah, exactly. The outer/inner terminology is really only sensible > for join nodes, but there isn't a third child-plan pointer reserved > for single-child node types, so you gotta use one of those. And > conventionally we use the "outer" one. > > regards, tom lane
Great, thanks for the explanation Alvaro and Tom; I'll fix that up in my next patch series. I idly wonder if a macro childPlanState() defined exactly the same as outerPlanState() might _kinda_ make sense here, but I'm also content to follow convention. I might submit a small patch to the comment on those macros though to expand on the explanation. James
